Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chrony configuration #83

Closed
wants to merge 2 commits into from
Closed

Conversation

zmc
Copy link

@zmc zmc commented Oct 15, 2020

To get ocp4-playbooks to properly deploy the chonryd configuration, I needed these changes

zmc added 2 commits October 14, 2020 16:42
The change in f7cd663 causes ignition to fail, for me.

Signed-off-by: Zack Cerza <zack@redhat.com>
1ffcf9a appears the have broken this.

Signed-off-by: Zack Cerza <zack@redhat.com>
@lukebrowning
Copy link

@yussufsh Can you give us a quick review? This is also part of the redhat ocs ci work for power.

@zmc
Copy link
Author

zmc commented Oct 21, 2020

Also - 0c8e27d fixes a regression

@@ -21,6 +21,7 @@
'source': 'data:text/plain;charset=utf-8;base64,' + chrony_b64,
'verification': {}
},
'filesystem': 'root',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try this with ignition configuration Specification v3? Since OCP 4.6 is using ignition spec v3.1 we cannot use filesystem.

If you are planning to use stable OCP 4.5 release then please switch to release-4.5 branch of this repository.

@yussufsh
Copy link
Contributor

@yussufsh Can you give us a quick review? This is also part of the redhat ocs ci work for power.

Sorry I had a review comment in pending state.

@yussufsh
Copy link
Contributor

yussufsh commented Oct 22, 2020

Also - 0c8e27d fixes a regression

This regression issue if changed will affect other project we have for PowerVS. When not using localhost as host entry in the inventory the chrony files gets created on /.

Something to be fixed in helpernode. Better fix would be to define an inventory with bastion ip instead of localhost as in https://github.com/ocp-power-automation/ocp4-upi-powervs/blob/master/modules/5_install/templates/helpernode_inventory

@zmc
Copy link
Author

zmc commented Oct 26, 2020

ok, @yussufsh - thanks for the explanation. I'll close this in favor of ocp-power-automation/ocp4-upi-kvm#61.

@zmc zmc closed this Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants