-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chrony configuration #83
Conversation
@yussufsh Can you give us a quick review? This is also part of the redhat ocs ci work for power. |
Also - 0c8e27d fixes a regression |
@@ -21,6 +21,7 @@ | |||
'source': 'data:text/plain;charset=utf-8;base64,' + chrony_b64, | |||
'verification': {} | |||
}, | |||
'filesystem': 'root', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try this with ignition configuration Specification v3? Since OCP 4.6 is using ignition spec v3.1 we cannot use filesystem
.
If you are planning to use stable OCP 4.5 release then please switch to release-4.5
branch of this repository.
Sorry I had a review comment in pending state. |
This regression issue if changed will affect other project we have for PowerVS. When not using localhost as host entry in the inventory the chrony files gets created on Something to be fixed in helpernode. Better fix would be to define an inventory with bastion ip instead of localhost as in https://github.com/ocp-power-automation/ocp4-upi-powervs/blob/master/modules/5_install/templates/helpernode_inventory |
ok, @yussufsh - thanks for the explanation. I'll close this in favor of ocp-power-automation/ocp4-upi-kvm#61. |
To get ocp4-playbooks to properly deploy the chonryd configuration, I needed these changes